feat: add IAPSettings as a direct resource #3493
Conversation
jingyih
force-pushed
the
IAPSettings_controller
branch
from
05c5dda to
f7e2912
Compare
jingyih
force-pushed
the
IAPSettings_controller
branch
from
f7e2912 to
ac5825f
Compare
jingyih
force-pushed
the
IAPSettings_controller
branch
from
ac5825f to
01f9159
Compare
There was a problem hiding this comment.
/assign @jasonvigil Could you help reviewing this resource?
jingyih
force-pushed
the
IAPSettings_controller
branch
from
01f9159 to
5a48958
Compare
|
PR is rebased and ready for review. |
| @@ -32,11 +32,11 @@ import ( | |||
| // projects/{projects_id}/iap_web | |||
| // projects/{projects_id}/iap_web/compute | |||
| // projects/{projects_id}/iap_web/compute-{region} | |||
| // projects/{projects_id}/iap_web/compute/service/{service_id} | |||
| // projects/{projects_id}/iap_web/compute-{region}/service/{service_id} | |||
| // projects/{projects_id}/iap_web/compute/services/{service_id} | |||
There was a problem hiding this comment.
Just curious, how did we discover this format / realize we needed to change the pattern here?
There was a problem hiding this comment.
A couple of months ago, I reached out to the IAP team to inquire about the format of this field. We'll need to manually test it to determine the format. e.g.
$ gcloud iap settings get --project=cnrm-jingyih-oncall --resource-type=compute --region=us-central1 --service=computebackendservice-3vcb62pjjxfhg6a
name: projects/441062683835/iap_web/compute-us-central1/services/1841600559922189902
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 01d70f9
into
GoogleCloudPlatform:master
This PR builds on #2785.