-
Notifications
You must be signed in to change notification settings - Fork 259
feat: allow user-specified connection ID in BigQueryConnection Connection #3153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…QueryConnection Connection
/assign @yuwenma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Looks great. a few nits ( I think we want to fix the immutable check)
But feel free to unhold and do it in follow-up PRs
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
We could merge this manually if this is blocking the release. Sample test is flaky. First run failed with
Second run failed with
I just triggered a 3rd run. |
Allow user to specify connection ID in
BigQueryConnectionConnection
viaspec.ResourceID
field.Fixes #3140