Skip to content

feat: allow user-specified connection ID in BigQueryConnection Connection #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

jingyih
Copy link
Collaborator

@jingyih jingyih commented Nov 12, 2024

Allow user to specify connection ID in BigQueryConnectionConnection via spec.ResourceID field.

// Immutable. Optional.
// The BigQuery Connection ID used for resource creation or acquisition.
// For creation: If specified, this value is used as the connection ID. If not provided, a UUID is generated and stored in the `status.ExternalRef` field.
// For acquisition: This field must be provided to identify the connection resource to acquire.
ResourceID *string `json:"resourceID,omitempty"`

Fixes #3140

@jingyih
Copy link
Collaborator Author

jingyih commented Nov 12, 2024

/assign @yuwenma

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Looks great. a few nits ( I think we want to fix the immutable check)
But feel free to unhold and do it in follow-up PRs

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 12, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Nov 12, 2024

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 12, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 12, 2024

/hold cancel

@jingyih
Copy link
Collaborator Author

jingyih commented Nov 12, 2024

We could merge this manually if this is blocking the release. Sample test is flaky. First run failed with

2024-11-12T20:20:25.1143716Z         --- FAIL: TestAllInSeries/samples/workerpool-with-peered-network (240.79s)

Second run failed with

2024-11-12T21:33:03.1181469Z         --- FAIL: TestAllInSeries/samples/bigquerydatatransferconfig-scheduledquery (181.73s)

I just triggered a 3rd run.

@yuwenma yuwenma merged commit 75e05f0 into GoogleCloudPlatform:master Nov 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQueryConnectionConnection resourceID requires UUID format but the API does not
2 participants