-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(compute): add compute disk create secondary regional sample #9641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cfd7a6c
Implemented compute_disk_create_secondary_regional. created test
TetyanaYahodska c6a4006
Fixed test
TetyanaYahodska 316add2
Fixed test
TetyanaYahodska 3f7445c
Fixed test
TetyanaYahodska 668752f
Fixed zone
TetyanaYahodska 43ef8a1
Fixed naming
TetyanaYahodska b258e92
Fixed spaces
TetyanaYahodska 87072f9
Fixed code
TetyanaYahodska 983c32b
Fixed indentations
TetyanaYahodska 91d0bbf
Fixed variable
TetyanaYahodska 61ffe38
Merge branch 'main' into compute_create_secondary_disk
TetyanaYahodska ba184d0
Fixed code
TetyanaYahodska 03c9dcb
Merge branch 'main' into compute_create_secondary_disk
TetyanaYahodska 6b6f8ba
Merge branch 'main' into compute_create_secondary_disk
TetyanaYahodska bf851d2
Added cleanup methods
TetyanaYahodska d6cd5af
Resolved merge conflict
TetyanaYahodska 0da2d72
Fixed lint issue
TetyanaYahodska 52cb9b9
Fixed lint issue
TetyanaYahodska f5108c2
Fixed test
TetyanaYahodska 64c15f3
Resolved merge conflict
TetyanaYahodska 545b7ef
Fixed code
TetyanaYahodska d863a9a
Fixed code
TetyanaYahodska 9262c78
Fixed code
TetyanaYahodska 025ab5a
Resolved merge conflict
TetyanaYahodska 1b75b5e
Deleted duplicated assertion
TetyanaYahodska 64c2cc6
Merge branch 'main' into compute_create_secondary_disk
TetyanaYahodska cac1ffd
Merge branch 'main' into compute_create_secondary_disk
TetyanaYahodska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
103 changes: 103 additions & 0 deletions
103
compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package compute.disks; | ||
|
||
// [START compute_disk_create_secondary_regional] | ||
import com.google.cloud.compute.v1.Disk; | ||
import com.google.cloud.compute.v1.DiskAsyncReplication; | ||
import com.google.cloud.compute.v1.Operation; | ||
import com.google.cloud.compute.v1.Operation.Status; | ||
import com.google.cloud.compute.v1.RegionDisksClient; | ||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.concurrent.ExecutionException; | ||
import java.util.concurrent.TimeUnit; | ||
import java.util.concurrent.TimeoutException; | ||
|
||
public class CreateDiskSecondaryRegional { | ||
public static void main(String[] args) | ||
throws IOException, ExecutionException, InterruptedException, TimeoutException { | ||
// TODO(developer): Replace these variables before running the sample. | ||
// The project that contains the primary disk. | ||
String primaryProjectId = "PRIMARY_PROJECT_ID"; | ||
// The project that contains the secondary disk. | ||
String secondaryProjectId = "SECONDARY_PROJECT_ID"; | ||
// Name of the primary disk you want to use. | ||
String primaryDiskName = "PRIMARY_DISK_NAME"; | ||
// Name of the disk you want to create. | ||
String secondaryDiskName = "SECONDARY_DISK_NAME"; | ||
// Name of the region in which your primary disk is located. | ||
// Learn more about zones and regions: | ||
// https://cloud.google.com/compute/docs/disks/async-pd/about#supported_region_pairs | ||
String primaryDiskRegion = "us-central1"; | ||
// Name of the region in which you want to create the secondary disk. | ||
String secondaryDiskRegion = "us-east1"; | ||
// Size of the new disk in gigabytes. | ||
// Learn more about disk requirements: | ||
// https://cloud.google.com/compute/docs/disks/async-pd/configure?authuser=0#disk_requirements | ||
long diskSizeGb = 30L; | ||
// The type of the disk you want to create. This value uses the following format: | ||
// "projects/{projectId}/zones/{zone}/diskTypes/ | ||
// (pd-standard|pd-ssd|pd-balanced|pd-extreme)". | ||
String diskType = String.format( | ||
"projects/%s/regions/%s/diskTypes/pd-balanced", secondaryProjectId, secondaryDiskRegion); | ||
|
||
createDiskSecondaryRegional(primaryProjectId, secondaryProjectId, primaryDiskName, | ||
secondaryDiskName, primaryDiskRegion, secondaryDiskRegion, diskSizeGb, diskType); | ||
} | ||
|
||
// Creates a secondary disk in a specified region. | ||
public static Status createDiskSecondaryRegional(String projectId, | ||
String secondaryProjectId, String primaryDiskName, String secondaryDiskName, | ||
String primaryDiskRegion, String secondaryDiskRegion, long diskSizeGb, String diskType) | ||
throws IOException, ExecutionException, InterruptedException, TimeoutException { | ||
List<String> replicaZones = Arrays.asList( | ||
String.format("projects/%s/zones/%s-c", secondaryProjectId, secondaryDiskRegion), | ||
String.format("projects/%s/zones/%s-b", secondaryProjectId, secondaryDiskRegion)); | ||
|
||
String primaryDiskSource = String.format("projects/%s/regions/%s/disks/%s", | ||
projectId, primaryDiskRegion, primaryDiskName); | ||
|
||
// Initialize client that will be used to send requests. This client only needs to be created | ||
// once, and can be reused for multiple requests. | ||
try (RegionDisksClient disksClient = RegionDisksClient.create()) { | ||
DiskAsyncReplication asyncReplication = DiskAsyncReplication.newBuilder() | ||
.setDisk(primaryDiskSource) | ||
.build(); | ||
|
||
Disk disk = Disk.newBuilder() | ||
.addAllReplicaZones(replicaZones) | ||
.setName(secondaryDiskName) | ||
.setSizeGb(diskSizeGb) | ||
.setType(diskType) | ||
.setRegion(secondaryDiskRegion) | ||
.setAsyncPrimaryDisk(asyncReplication) | ||
.build(); | ||
|
||
// Wait for the create disk operation to complete. | ||
Operation response = disksClient.insertAsync(secondaryProjectId, secondaryDiskRegion, disk) | ||
.get(3, TimeUnit.MINUTES); | ||
|
||
if (response.hasError()) { | ||
throw new Error("Error creating secondary disks! " + response.getError()); | ||
} | ||
return response.getStatus(); | ||
} | ||
} | ||
} | ||
// [END compute_disk_create_secondary_regional] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this Operation only takes 3 minutes to run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for other operations, 3 minutes was enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the same case with this operation as well? We don't want flaky tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also set it to 3 minutes for other disk creation operations. Why should it be different in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming if this is enough time. Not opposing your claim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is enough time. The test passed without errors.