Skip to content

Automl GA #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 15, 2019
Merged

Automl GA #1729

merged 12 commits into from
Nov 15, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Nov 12, 2019

Add samples for the AutoML GA of:

  • Natural Language (New samples)
    • Text Classification
    • Entity Extraction
    • Sentiment Analysis
  • Vision (New samples)
    • Image Classification
    • Object Detection
  • Translation (Lint updates)

@nnegrey nnegrey requested a review from a team November 12, 2019 21:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019
kurtisvg
kurtisvg suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future can we break these into smaller CLs? 44 is a little hard to review at once.

kurtisvg
kurtisvg approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, otherwise LGTM

@nnegrey nnegrey merged commit 81ff240 into master Nov 15, 2019
@nnegrey nnegrey deleted the automl-ga branch November 15, 2019 21:52
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
@nnegrey @chingor13
samples: Automl GA (#1729)
cc93727 
* Add Natural Language GA Samples

* Add Undeploy Model

* Add Vision Classification Samples

* Add Vision Object Detection Samples

* Lint

* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests

* Add comment to explain why the create model call doesn't wait for compeletion

* Update comment wording

* Update method comment, only check env var for tests before class, remove javadoc comments
@Shabirmean Shabirmean mentioned this pull request Nov 17, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
@nnegrey @Shabirmean
samples: Automl GA (#1729)
a55aac1 
* Add Natural Language GA Samples

* Add Undeploy Model

* Add Vision Classification Samples

* Add Vision Object Detection Samples

* Lint

* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests

* Add comment to explain why the create model call doesn't wait for compeletion

* Update comment wording

* Update method comment, only check env var for tests before class, remove javadoc comments
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
@nnegrey @anguillanneuf
samples: Automl GA (#1729)
de1bebb 
* Add Natural Language GA Samples

* Add Undeploy Model

* Add Vision Classification Samples

* Add Vision Object Detection Samples

* Lint

* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests

* Add comment to explain why the create model call doesn't wait for compeletion

* Update comment wording

* Update method comment, only check env var for tests before class, remove javadoc comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnegrey @kurtisvg @googlebot