-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parametermanager): Added global and regional samples for parameter manager #10028
feat(parametermanager): Added global and regional samples for parameter manager #10028
Conversation
@gptSanyam Can you provide valid product team for the parameter manager for adding in CODEOWNERS and Blunderbuss issue/PR auto-assigner |
…tform#10032) * feat(parametermanager): created folder to add samples * feat(parametermanager): created folder to add samples
Tests failure pending b/404406746 |
Hello @vatsal-vora-crestdata -- this PR is too large. Please break this into multiple PRs < 500 LoC each. Thank you. |
@telpirion I have divided this PR into multiple smaller PRs |
unsubscribe
Best regards,
Gábor Czakó | Eng. Manager | ***@***.*** | +
…On Wed, 26 Mar 2025 at 13:05, vatsal-vora-crestdata < ***@***.***> wrote:
Hello @vatsal-vora-crestdata <https://github.com/vatsal-vora-crestdata>
-- this PR is too large. Please break this into multiple PRs < 500 LoC
each. Thank you.
@telpirion <https://github.com/telpirion> I have divided this PR into
multiple smaller PRs
#10048
<#10048>,
#10049
<#10049>,
#10050
<#10050>,
#10051
<#10051>,
#10052
<#10052>,
#10053
<#10053>,
#10054
<#10054>
—
Reply to this email directly, view it on GitHub
<#10028 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPPCEFCL2LUNCILNTZ33ACD2WKJX3AVCNFSM6AAAAABXTERDIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJUGE3TMOJSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
[image: vatsal-vora-crestdata]*vatsal-vora-crestdata* left a comment
(GoogleCloudPlatform/java-docs-samples#10028)
<#10028 (comment)>
Hello @vatsal-vora-crestdata <https://github.com/vatsal-vora-crestdata>
-- this PR is too large. Please break this into multiple PRs < 500 LoC
each. Thank you.
@telpirion <https://github.com/telpirion> I have divided this PR into
multiple smaller PRs
#10048
<#10048>,
#10049
<#10049>,
#10050
<#10050>,
#10051
<#10051>,
#10052
<#10052>,
#10053
<#10053>,
#10054
<#10054>
—
Reply to this email directly, view it on GitHub
<#10028 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPPCEFCL2LUNCILNTZ33ACD2WKJX3AVCNFSM6AAAAABXTERDIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJUGE3TMOJSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Description
Created samples for Global and Regional Parameter Manager API
Samples (Global, Regional)
quickstart
parameter-structured-data
parameter-unstructured-data
add-parameter-version (structured, unstructured)
create-parameter-secret-reference
list-all-parameters
view-parameter-details
delete-parameter
list-all-parameters-versions
view-parameter-version-details
render-secret-parameter-version
disable-parameters-version
enable-disabled-parameters-version
delete-parameter-version
Checklist
pom.xml
parent set to latestshared-configuration
GOOGLE_CLOUD_PROJECT
andGOOGLE_CLOUD_PROJECT_LOCATION
to be set.mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only