Skip to content

chore: remove unused ConfigMap #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Aug 22, 2023

Resolves: #96

@rosmo
Copy link
Collaborator

rosmo commented Aug 28, 2023

Can you also remove the unused configmap in the Terraform code since you are at it? (https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/terraform/kubernetes/main.tf#L215)

@jawnsy
Copy link
Contributor Author

jawnsy commented Aug 28, 2023

@rosmo Thanks, removed! PTAL

@rosmo rosmo merged commit 6c496bd into GoogleCloudPlatform:master Sep 26, 2023
@jawnsy jawnsy deleted the remove-configmap branch September 28, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused ConfigMap in deploy manifest
2 participants