Skip to content

Do not block deletion if NEG status is empty #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 16, 2023

Conversation

fdfzcq
Copy link
Contributor

@fdfzcq fdfzcq commented Mar 15, 2023

Fix a bug where an empty cloud.google.com/neg-status blocks deletion of the service resource.

To reproduce the bug:

  • create a new service.yaml with autoneg annotations pointing to an invalid port
  • try removing the service resource manually, the deletion hangs
  • the deletion completes if we patch the resource with finalizers:null

@google-cla
Copy link

google-cla bot commented Mar 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fdfzcq fdfzcq changed the title [WIP] Do not block deletion if NEG status is empty Do not block deletion if NEG status is empty Mar 16, 2023
@rosmo
Copy link
Collaborator

rosmo commented Mar 16, 2023

Would love to merge this. @fdfzcq I think you need to put in your corp email to Github for the CLA check to work.

@fdfzcq
Copy link
Contributor Author

fdfzcq commented Mar 16, 2023

@rosmo I'm looking into failed tests

@rosmo
Copy link
Collaborator

rosmo commented Mar 16, 2023

@fdfzcq Good to merge?

@fdfzcq
Copy link
Contributor Author

fdfzcq commented Mar 16, 2023

@rosmo I think we are good to go! Can you make a new release when this is merged? Thank you!

@rosmo rosmo merged commit e8d87c3 into GoogleCloudPlatform:master Mar 16, 2023
@rosmo
Copy link
Collaborator

rosmo commented Mar 16, 2023

Made 0.9.9 release :)

@fdfzcq
Copy link
Contributor Author

fdfzcq commented Mar 17, 2023

@rosmo thank you!

@fdfzcq fdfzcq deleted the fix-deletion-bug branch March 17, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants