-
Notifications
You must be signed in to change notification settings - Fork 54
Do not block deletion if NEG status is empty #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Would love to merge this. @fdfzcq I think you need to put in your corp email to Github for the CLA check to work. |
@rosmo I'm looking into failed tests |
@fdfzcq Good to merge? |
@rosmo I think we are good to go! Can you make a new release when this is merged? Thank you! |
Made 0.9.9 release :) |
@rosmo thank you! |
Fix a bug where an empty
cloud.google.com/neg-status
blocks deletion of the service resource.To reproduce the bug:
finalizers:null