Add initial capacity setting #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawnsy
commented
Nov 19, 2022
jawnsy
commented
Nov 19, 2022
jawnsy
force-pushed
the
add-initial-capacity
branch
from
8c95007 to
5877225
Compare
jawnsy
commented
Nov 19, 2022
jawnsy
commented
Nov 19, 2022
|
I think this should be ready for a review when you have a chance, @rosmo 😄 |
|
Just checking up on this, whether it's still valid. |
jawnsy
force-pushed
the
add-initial-capacity
branch
from
5877225 to
ca4f072
Compare
jawnsy
commented
Jun 11, 2023
|
@rosmo Hey, would you be able to take another look at this? I think it should be good to merge now! |
|
Could you please rebase this and it should be good to go? |
Allow users to customize the initial capacity scaler setting. This feature is useful for traffic steering scenarios, such as blue/green deployments, whereby a new service can be brought online without receiving any traffic.
jawnsy
force-pushed
the
add-initial-capacity
branch
from
8715789 to
86779e9
Compare
jawnsy
commented
Aug 22, 2023
|
@rosmo I've rebased and squashed my commits as well |
|
any plans to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to customize the initial capacity scaler setting. This feature is useful for traffic steering scenarios, such as blue/green deployments, whereby a new service can be brought online without receiving any traffic.
Closes: #68