Skip to content

fix: set GO111MODULE=on when install conformance tool #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2020
Merged

fix: set GO111MODULE=on when install conformance tool #44

merged 2 commits into from
Oct 19, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Oct 16, 2020

This enables go get to fetch the correct versions of the modules the conformance tool depends on. Also, run the tool with client command because go get and go run both build the Go binary so running go run is not needed.

Fixes issue #40

@hdp617 hdp617 requested review from grant and mtraver October 16, 2020 22:52
@hdp617 hdp617 merged commit e113ac0 into master Oct 19, 2020
@grant grant deleted the hdp617-patch-1 branch November 19, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtraver mtraver mtraver approved these changes

@grant grant Awaiting requested review from grant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdp617 @mtraver