Loosen requirements on the data payload of CloudEvents. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a legacy event is converted to a CloudEvent, we know that we want a certain JSON payload, but we shouldn't require that payload to be formatted exactly the same as the JSON payload in our golden files. Instead, we unmarshal both the actual and expected values into maps, and we check that those maps are equal.
eamonnmcmanus
added a commit
to GoogleCloudPlatform/functions-framework-java
that referenced
this pull request
Sep 10, 2020
This allows received Legacy Events to be handled by function code that expects a CloudEvent input. The translation logic and tests are based closely on the corresponding code in https://github.com/GoogleCloudPlatform/functions-framework-dotnet. The new code also passes the relevant conformance tests in https://github.com/GoogleCloudPlatform/functions-framework-conformance, once GoogleCloudPlatform/functions-framework-conformance#30 is applied. For now I'm running those tests manually. I plan at least to commit the script and test functions that allow me to do so.
eamonnmcmanus
added a commit
to GoogleCloudPlatform/functions-framework-java
that referenced
this pull request
Sep 11, 2020
* Add explanatory comments to the new code in BackgroundFunctionExecutor. * Add logic to convert from Legacy Events to CloudEvents. This allows received Legacy Events to be handled by function code that expects a CloudEvent input. The translation logic and tests are based closely on the corresponding code in https://github.com/GoogleCloudPlatform/functions-framework-dotnet. The new code also passes the relevant conformance tests in https://github.com/GoogleCloudPlatform/functions-framework-conformance, once GoogleCloudPlatform/functions-framework-conformance#30 is applied. For now I'm running those tests manually. I plan at least to commit the script and test functions that allow me to do so.
roffjulie
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a legacy event is converted to a CloudEvent, we know that we want a certain
JSON payload, but we shouldn't require that payload to be formatted exactly the
same as the JSON payload in our golden files. Instead, we unmarshal both the
actual and expected values into maps, and we check that those maps are equal.