Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(storage): add samples and test cases for storage to support bucket restore feature #2963

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mahendra-google
Copy link

PR supports list soft deleted bucket, restore soft deleted bucket, get soft deleted bucket samples and test cases.

  • 1. Addition of sample and test case to list soft deleted bucket (storage_list_soft_deleted_buckets)
  • 2. Addition of sample and test case to restore soft deleted bucket (storage_restore_bucket)
  • 3. Addition of sample and test case to get soft deleted bucket (storage_get_soft_deleted_bucket)

@mahendra-google mahendra-google requested review from a team as code owners March 19, 2025 10:43
Copy link

snippet-bot bot commented Mar 19, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Mar 19, 2025
@amanda-tarafa amanda-tarafa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2025
@amanda-tarafa
Copy link
Member

Tests are failing to build:

/tmpfs/src/github/dotnet-docs-samples/storage/api/Storage.Samples.Tests/RestoreBucketTest.cs(37,109): error CS1503: Argument 2: cannot convert from 'long?' to 'long' [/tmpfs/src/github/dotnet-docs-samples/storage/api/Storage.Samples.Tests/Storage.Samples.Tests.csproj]

@mahendra-google
Copy link
Author

Tests are failing to build:

/tmpfs/src/github/dotnet-docs-samples/storage/api/Storage.Samples.Tests/RestoreBucketTest.cs(37,109): error CS1503: Argument 2: cannot convert from 'long?' to 'long' [/tmpfs/src/github/dotnet-docs-samples/storage/api/Storage.Samples.Tests/Storage.Samples.Tests.csproj]

@amanda-tarafa Test case updated

@amanda-tarafa amanda-tarafa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2025
@google-admin google-admin reopened this Mar 21, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mahendra-google
Copy link
Author

@amanda-tarafa Test CopyFileArchivedGenerationTest is passing locally for me which is failing in Kokoro Windows 3.

  at CopyFileArchivedGenerationTest.CopyFileArchivedGeneration() in C:\tmpfs\src\github\dotnet-docs-samples\storage\api\Storage.Samples.Tests\CopyFileArchivedGenerationTest.cs:line 66 

@amanda-tarafa
Copy link
Member

@amanda-tarafa Test CopyFileArchivedGenerationTest is passing locally for me which is failing in Kokoro Windows 3.

  at CopyFileArchivedGenerationTest.CopyFileArchivedGeneration() in C:\tmpfs\src\github\dotnet-docs-samples\storage\api\Storage.Samples.Tests\CopyFileArchivedGenerationTest.cs:line 66 

Yes, don't worry, this is a known flake that we are tracking in #1563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants