Skip to content
This repository was archived by the owner on Apr 18, 2022. It is now read-only.

Remove unused code. #53

Merged
merged 1 commit into from
Mar 25, 2016
Merged

Conversation

jamesbyars
Copy link
Contributor

The call to get the File object is not used in startCamera(), also getCameraFile() is taking care of getting the File, no need to make the same call in startCamera()

The call to get the File object is not used in startCamera(), also getCameraFile() is taking care of getting the File, no need to make the same call in startCamera()
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jamesbyars
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@jamesbyars
Copy link
Contributor Author

Build failure appears to be related to an environment variable setting used by Travis-ci. I see in the docs that the build should use the GOOGLE_APPLICATION_CREDENTIALS environment variable.

Here is the failure from Travis-ci:
Error: Received unexpected error "google: error getting credentials using GOOGLE_APPLICATION_CREDENTIALS environment variable: unexpected end of JSON input"

Related to #50

@jerjou jerjou merged commit 7ad1cb1 into GoogleCloudPlatform:master Mar 25, 2016
@jerjou
Copy link
Contributor

jerjou commented Mar 25, 2016

Thanks!

@jamesbyars jamesbyars deleted the patch-1 branch March 26, 2016 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants