chore: Add domainName to instance configuration, part of #421. #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-421-refactor-refresh
branch
from
8743264 to
51dfbe4
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
8cbfbaa to
7f75770
Compare
hessjcg
force-pushed
the
gh-421-refactor-refresh
branch
2 times, most recently
from
75fdb37 to
54ef048
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
7f75770 to
fa16e6a
Compare
hessjcg
force-pushed
the
gh-421-refactor-refresh
branch
from
54ef048 to
d838204
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
2 times, most recently
from
59dc310 to
03cc7cc
Compare
hessjcg
force-pushed
the
gh-421-refactor-refresh
branch
2 times, most recently
from
330c007 to
f4f69c1
Compare
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
2 times, most recently
from
7faa99b to
303333c
Compare
chore: Resolve DNS TXT record to instance name. Part of DNS Config. wip: merge down parse-instance-connection-name.ts
hessjcg
force-pushed
the
gh-421-dns-configuration
branch
from
303333c to
347eb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
InstanceConnectionNameandparseInstanceConnectionName()to allow DNS namesas well as instance connection names. Add test cases to cover DNS Names. Add new dns-lookup.ts
that looks up the instance connection name from a DNS name using the TXT record.
Part of #421