Skip to content

feat(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 8, 2022
Merged

feat(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f13f7b
fix(jdbc/mysql-j-5): testing native image support for jdbc/mysql-j-5 …
mpeddada1 Aug 31, 2022
91442af
Update run_tests_graalvm_native.sh
mpeddada1 Sep 2, 2022
c4c791b
register resource
mpeddada1 Sep 2, 2022
2cb7e78
Merge branch 'main' into patch-1
mpeddada1 Sep 2, 2022
292a9b6
rename resource file path to follow convention
mpeddada1 Sep 6, 2022
bad8fef
bring back jdbc/postgresql
mpeddada1 Sep 6, 2022
d7f1020
add configs to CloudSqlFeature
mpeddada1 Sep 6, 2022
1c15ab0
fix formatting
mpeddada1 Sep 6, 2022
8b506c5
Merge branch 'main' into patch-1
shubha-rajan Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .kokoro/tests/run_tests_graalvm_native.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ declare -i return_code=0
# jdbc/mysql-j-5 jdbc/mysql-j-8 jdbc/sqlserver r2dbc/sqlserver r2dbc/sqlserver
# r2dbc/mysql
# https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/issues/824
for test_directory in jdbc/postgres; do
for test_directory in jdbc/postgres jdbc/mysql-j-8; do
pushd ${test_directory}
echo -e "******************** Running tests in ${test_directory} ********************\n"
# Dependency convergence enforcer rule would fail with the junit dependencies
Expand All @@ -56,4 +56,4 @@ for test_directory in jdbc/postgres; do
echo -e "******************** Tests complete in ${test_directory}, result: $result ********************\n"
popd
done
exit ${return_code}
exit ${return_code}
2 changes: 2 additions & 0 deletions core/src/main/java/com/google/cloud/sql/nativeimage/CloudSqlFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ public void beforeAnalysis(BeforeAnalysisAccess access) {

NativeImageUtils.registerConstructorsForReflection(
access, "com.mysql.cj.conf.url.SingleConnectionUrl");
resourcesRegistry.addResources(ConfigurationCondition.alwaysTrue(),
"\\Qcom/mysql/cj/util/TimeZoneMapping.properties\\E");

// for mysql-j-5
NativeImageUtils.registerConstructorsForReflection(
Expand Down