feat: Automatically configure connections using DNS. Part of #2043. #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
2665b01 to
c41d806
Compare
hessjcg
force-pushed
the
gh-2043-java-dns-wrapper
branch
from
300da39 to
cb75da8
Compare
hessjcg
force-pushed
the
gh-2043-configure-with-dns
branch
from
c41d806 to
46e95c4
Compare
enocom
reviewed
Jul 22, 2024
| package com.google.cloud.sql.core; | ||
|
|
||
| /** Resolves the Cloud SQL Instance from the configuration name. */ | ||
| interface InstanceConnectionNameResolver { |
There was a problem hiding this comment.
I think it's fine to make this package private for now -- but you'll want to plan for making this interface public so that callers can configure their own resolver.
There was a problem hiding this comment.
See #1153 as an example of someone who already asked for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection may be configured to using a DNS name instead of an instance name. If the cloudSqlInstance property is
set to be a domain name instead of an instance name, the connector will look up a SRV record for that name and
connect to that instance.
There should be exactly 1 SRV for the database instance. The connector will always use the SRV record with the
highest priority.
Part of #2043