Skip to content

Set executor shutdown time to 0 to prevent application hanging. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2019
Merged

Set executor shutdown time to 0 to prevent application hanging. #144

merged 2 commits into from
Jun 17, 2019

Conversation

kurtisvg
Copy link
Contributor

No description provided.

@kurtisvg kurtisvg requested a review from netdpb June 14, 2019 20:23
@netdpb
Copy link

netdpb commented Jun 14, 2019

Exiting executors should quit immediately unless they're currently running something. But scheduled executors won't (by default) if they have unstarted tasks. To make the executor cancel unstarted tasks on exit, I think you should call executor.setExecuteExistingDelayedTasksAfterShutdownPolicy(false) instead.

@kurtisvg kurtisvg added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 15, 2019
@kurtisvg kurtisvg merged commit 51f8346 into master Jun 17, 2019
@kurtisvg kurtisvg deleted the fast-shutdown branch June 17, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netdpb netdpb netdpb approved these changes

Assignees
No one assigned
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtisvg @netdpb