Skip to content

Add unit tests for isValidDomain #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackwotherspoon opened this issue Jan 28, 2025 · 0 comments
Open

Add unit tests for isValidDomain #2110

jackwotherspoon opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@jackwotherspoon
Copy link
Collaborator

The regex used to validate domain names in this library is not able to compile in
languages like Go due to lookahead assertions. As such, we should add unit tests
around isValidDomain to test common test cases and domain names.

This will allow for differing regex to have a baseline of tested common paths.

@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants