Skip to content

Add unit tests for isValidDomain #2110

Open
@jackwotherspoon

Description

@jackwotherspoon

The regex used to validate domain names in this library is not able to compile in
languages like Go due to lookahead assertions. As such, we should add unit tests
around isValidDomain to test common test cases and domain names.

This will allow for differing regex to have a baseline of tested common paths.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions