Add unit tests for isValidDomain
#2110
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
The regex used to validate domain names in this library is not able to compile in
languages like Go due to lookahead assertions. As such, we should add unit tests
around
isValidDomain
to test common test cases and domain names.cloud-sql-jdbc-socket-factory/core/src/main/java/com/google/cloud/sql/core/CloudSqlInstanceName.java
Line 68 in 595e620
This will allow for differing regex to have a baseline of tested common paths.
The text was updated successfully, but these errors were encountered: