Skip to content

Test new tck framework #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Test new tck framework #270

merged 4 commits into from
Oct 23, 2020

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Sep 23, 2020

Remove TCK test overrides that were necessary due to DML syntax requiring column list in Spanner.

R2DBC SPI 0.8.3 containing the TCK changes was released. I also upgraded Reactor to the same version that's in SPI.

There are still two reasons for overrides:

  1. Spanner returning Long even when Integer is requested -- work tracked in Determine correct behavior for Row.get("column", Integer.class) #276.
  2. the driver breaking R2DBC spec by treating columns as case insensitive -- decision pending on Revisit case-sensitive column implementation #271.

@elefeint elefeint force-pushed the test-new-tck-framework branch from 8294061 to ae3e475 Compare October 22, 2020 22:36
@elefeint elefeint marked this pull request as ready for review October 22, 2020 22:43
@elefeint elefeint merged commit a76226b into master Oct 23, 2020
@elefeint elefeint deleted the test-new-tck-framework branch October 23, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants