Skip to content

Fix TCK test failures #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2019
Merged

Fix TCK test failures #175

merged 2 commits into from
Nov 21, 2019

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Nov 21, 2019 •
edited
Loading

Two reasons for failures:

  1. Cloud Spanner requires that columns be enumerated in insert statement.
  2. Cloud Spanner's "Integer" type is 64 bit, so it maps to a Java Long.

Also: renamed from Example to TestKit to conform to new naming convension.

In the long run, it would be nice to fix without overriding each test, hence r2dbc/r2dbc-spi#138.

@elefeint elefeint requested review from dzou and meltsufin November 21, 2019 20:58
meltsufin
meltsufin approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: how do we make sure that the tests we copied and then modified to be compatible with Spanner stay in sync with the source?

@elefeint
Copy link
Contributor Author

Watch the SPI repo, I suppose. But that's why I filed that issue -- it's a risk of falling behind for us to maintain a copy .

@elefeint elefeint merged commit aa53171 into master Nov 21, 2019
@elefeint elefeint deleted the tck-fix branch November 26, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@dzou dzou Awaiting requested review from dzou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elefeint @meltsufin