Skip to content

Implement Connection.validate #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elefeint opened this issue Aug 15, 2019 · 0 comments · Fixed by #173
Closed

Implement Connection.validate #162

elefeint opened this issue Aug 15, 2019 · 0 comments · Fixed by #173
Assignees
@elefeint

Comments

@elefeint
Copy link
Contributor

R2DBC SPI added a connection validation method on the interface in r2dbc/r2dbc-spi#54
@elefeint elefeint self-assigned this Nov 15, 2019
@elefeint elefeint mentioned this issue Nov 15, 2019
Merged
elefeint added a commit that referenced this issue Nov 20, 2019
@elefeint
Implement connection validation (#173)
107c976 
### Behavior change:
* Null out session when connection is closed.
* Local validation relies on having a valid session (it checks for session name, but that's only going to be non-null if and only if the connection is non-null.)
* Remote validation is implemented as a low-level `GrpcClient` healthcheck. It sends a trivial query to Spanner over `executeSql` (as opposed to `executeStreamingSql`).

### TCK test change:
* Removed session pools from TCK tests
* Suppressed error logging when already-existing tables try to get created. This operation also takes forever; need to check whether pre-querying tables will be faster.

Fixes #162 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement connection validation GoogleCloudPlatform/cloud-spanner-r2dbc
1 participant
@elefeint