added support 2nd generation cloud function

[som-nitjsr]

adding support for 2nd generation cloud function and using http trigger as in case of enterprise there are lot of data and it takes lots of time . In my case function was getting timed out. so moved it to second generation where http trigger has 60 minutes of time out.
#817

[juliocc]

Thanks for this PR. Really nice idea!

A few comments:

• Can we split this in two separate PRs, one for the Cloud Function module and another one for the changes networking dashboard.
• For the Cloud Function module, can you reuse the existing function_config.memory field instead of introducing memory_2ndGen?
• For the module again, can you change function_version to a simple boolean v2?

[som-nitjsr]

Thanks for this PR. Really nice idea!

A few comments:

• Can we split this in two separate PRs, one for the Cloud Function module and another one for the changes networking dashboard.
• For the Cloud Function module, can you reuse the existing function_config.memory field instead of introducing memory_2ndGen?
• For the module again, can you change function_version to a simple boolean v2?

Hi @juliocc i have addressed both comments.

[juliocc]

Thanks for the changes.

As a general note, it's bad practice to ask the user comment/uncomment code to toggle features. Can you adapt the code so that you have a flag to enable the use of CFv2 in the dashboard?

And finally, please make sure to format your terraform code using terraform fmt

[juliocc]

As a general note, it's bad practice to ask the user comment/uncomment code to toggle features. Can you adapt the code so that you have a flag to enable the use of CFv2 in the dashboard?

And finally, please make sure to format your terraform code using terraform fmt

You still haven't addressed these two points.

[som-nitjsr]

As a general note, it's bad practice to ask the user comment/uncomment code to toggle features. Can you adapt the code so that you have a flag to enable the use of CFv2 in the dashboard?
And finally, please make sure to format your terraform code using terraform fmt

You still haven't addressed these two points.
@juliocc i have done the changes.

[juliocc]

@som-nitjsr can you rebase and fix the conflicts?