Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project object c14n in separate file #2987

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Project object c14n in separate file #2987

merged 1 commit into from
Mar 30, 2025

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Mar 28, 2025 •
edited
Loading

Create separate file for canonicalization of project factory objects and introduce duplicate-diff lint checker.

TODO:

  • Do we need canonicalization of IAM variables, or they can just pass as is?

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added on:tools New or changed tool on:modules labels Mar 28, 2025
@wiktorn
Project object c14n in separte file
3ed2ad9 
Create separate file for canonicalization of project factory objects and
introduce duplicate-diff lint checker.
@wiktorn wiktorn merged commit 3e84236 into master Mar 30, 2025
19 checks passed
@wiktorn wiktorn deleted the wiktorn-pf-c14n branch March 30, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo