Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module: net-vpc-factory #2982

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Module: net-vpc-factory #2982

wants to merge 53 commits into from
+4,676 −0

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented Mar 25, 2025 •
edited
Loading

This pull request introduces the net-vpc-factory module. This new factory handles:

  • Project
  • VPC setup
  • Connectivity options
    • NCC (hub, VPC spokes and VPN hybrid spokes)
    • Peerings
    • VPN (GCP-to-onprem and GCP-to-GCP)
  • DNS (everything supported by the dns module)
  • Firewall (everything supported by the net-vpc-firewall module)

TODO:

  • Tests
  • Finalise docs (~)
  • Outputs

@sruffilli sruffilli marked this pull request as ready for review April 1, 2025 12:11
@sruffilli
Copy link
Collaborator Author

PR is 95% complete and ready for review.

@github-actions github-actions bot added on:tools New or changed tool and removed on:tools New or changed tool labels Apr 1, 2025
@wiktorn wiktorn force-pushed the sruffilli/fast-networking-factory branch from b477c2e to fa80947 Compare April 1, 2025 19:42
@wiktorn wiktorn force-pushed the sruffilli/fast-networking-factory branch from fa80947 to fd0cfe5 Compare April 2, 2025 07:13
@github-actions github-actions bot removed the on:tools New or changed tool label Apr 2, 2025
@sruffilli sruffilli requested review from ludoo, juliocc and LucaPrete April 4, 2025 07:05
@sruffilli
Copy link
Collaborator Author

@Rewiewers: I highly recommend starting from README.md to have a high level understanding (and/or to report missing key concepts).

juliocc
juliocc requested changes Apr 8, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo left review comments

@juliocc juliocc juliocc requested changes

@LucaPrete LucaPrete Awaiting requested review from LucaPrete

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sruffilli @ludoo @juliocc