Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifact-registry): Add possibility to setup Docker common remote repository configuration #2952

Conversation

anthonyhaussman
Copy link
Contributor

@anthonyhaussman anthonyhaussman commented Mar 12, 2025

Add the possibility to setup Docker common remote repository configuration to be able to have remote of internal Artifact Registry repository.

Ref: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/artifact_registry_repository#example-usage---artifact-registry-repository-remote-common-repository-with-docker


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@anthonyhaussman anthonyhaussman marked this pull request as ready for review March 12, 2025 17:20
@ludoo
Copy link
Collaborator

ludoo commented Mar 13, 2025

Thanks for this. Can you also add an example to the README?

…e repository configuration

Add the possibility to setup Docker common remote repository configuration to be able to have remote of internal Artifact Registry repository.
@anthonyhaussman anthonyhaussman force-pushed the tone/feat/artifact-registry_remote_common_repository branch from c509e6f to d04c0d3 Compare March 13, 2025 09:17
@anthonyhaussman
Copy link
Contributor Author

Thanks for this. Can you also add an example to the README?

Done in d04c0d3 @ludoo ☺️

@ludoo ludoo enabled auto-merge (squash) March 13, 2025 10:14
auto-merge was automatically disabled March 13, 2025 10:41

Head branch was pushed to by a user without write access

@anthonyhaussman anthonyhaussman force-pushed the tone/feat/artifact-registry_remote_common_repository branch from d04c0d3 to 459d3c5 Compare March 13, 2025 10:41
@ludoo ludoo enabled auto-merge (squash) March 13, 2025 10:52
auto-merge was automatically disabled March 13, 2025 11:01

Head branch was pushed to by a user without write access

@anthonyhaussman anthonyhaussman force-pushed the tone/feat/artifact-registry_remote_common_repository branch from 459d3c5 to 44d1628 Compare March 13, 2025 11:01
@anthonyhaussman anthonyhaussman force-pushed the tone/feat/artifact-registry_remote_common_repository branch from 44d1628 to 2609d70 Compare March 13, 2025 11:08
@anthonyhaussman anthonyhaussman force-pushed the tone/feat/artifact-registry_remote_common_repository branch from 2609d70 to 69bc9a4 Compare March 13, 2025 12:11
@juliocc juliocc enabled auto-merge (squash) March 13, 2025 12:18
@juliocc juliocc merged commit cca6f25 into GoogleCloudPlatform:master Mar 13, 2025
15 checks passed
@anthonyhaussman anthonyhaussman deleted the tone/feat/artifact-registry_remote_common_repository branch March 13, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants