Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow un-managed reverse lookup zones #2942

Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Mar 5, 2025

Allow creation of a lookup zones in Cloud DNS that have records (unmanaged). Add a flag to create managed zones, where records are added automatically.

I'm not sure what is the exact use case for managed reverse lookup zone, so I decided to make it a non-default option, and make an un-managed the default, happy to change that if managed approach is prevalent.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Breaking Changes

`modules/dns`: Reverse zones are by default created as unmanaged now. To keep your zone as managed, please set `var.zone_config.private.reverse_managed` to `true`

@wiktorn wiktorn added the breaks:modules Breaking changes in a module interface or resources. label Mar 5, 2025
@wiktorn wiktorn enabled auto-merge (rebase) March 5, 2025 08:32
@wiktorn wiktorn merged commit 6b6f5d8 into GoogleCloudPlatform:master Mar 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks:modules Breaking changes in a module interface or resources. on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants