Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bootstrap): fix custom roles billing viewer duplicate permissions #2927

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(bootstrap): fix custom roles billing viewer duplicate permissions #2927

merged 1 commit into from
Feb 24, 2025

Conversation

Ameausoone
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc
Copy link
Collaborator

juliocc commented Feb 24, 2025

Thanks for spotting and fixing this.

Is this PR ready for review?

@ludoo ludoo changed the base branch from master to fast-dev February 24, 2025 11:28
@juliocc juliocc changed the base branch from fast-dev to master February 24, 2025 11:32
@juliocc juliocc marked this pull request as ready for review February 24, 2025 11:52
@juliocc juliocc enabled auto-merge (squash) February 24, 2025 11:52
@juliocc juliocc merged commit ffeb751 into GoogleCloudPlatform:master Feb 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ameausoone @juliocc