Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limits for stage_names and environment #2924

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 23, 2025

Add validation to FAST variables. This follows "static" allocation of namespace to specific types, i.e.:

  • prefix 9 characters
  • environment 4 characters
  • stage 6 characters

etc.

It is possible, with more complex code, to check against current variables (i.e., check how long the prefix is, and what's the longest environment name, stage name etc.) and do the validation on the resource_names with checks or pre-condition on null resource.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn wiktorn force-pushed the wiktorn-stage-name-length branch from 649116c to ebdb6b5 Compare February 23, 2025 14:58
@wiktorn wiktorn force-pushed the wiktorn-stage-name-length branch from ebdb6b5 to d8df251 Compare February 23, 2025 17:21
@wiktorn wiktorn enabled auto-merge (rebase) February 23, 2025 17:21
@wiktorn wiktorn merged commit fea88ad into master Feb 23, 2025
19 checks passed
@wiktorn wiktorn deleted the wiktorn-stage-name-length branch February 23, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants