Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CICD SA access #2923

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Fix CICD SA access #2923

merged 1 commit into from
Feb 23, 2025

Conversation

c-jason-kim
Copy link
Contributor

@c-jason-kim c-jason-kim commented Feb 22, 2025

The stage2 CICD SAs were not being granted roles/iam.serviceAccountTokenCreator on the corresponding stage2 SAs. For whatever reason the code was appending "-prod" to the cicd-sa-ro/rw keys when adding them resulting in nulls.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Feb 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Feb 22, 2025

Thanks for spotting this. Our mistake, this escaped in the large set of changes we recently did to resman.

@ludoo
Copy link
Collaborator

ludoo commented Feb 22, 2025

Can you sign the CLA and fix the linting error?

@c-jason-kim
Copy link
Contributor Author

Apologies, obviously wasn't paying enough attention last night. Signed and linted.

@ludoo ludoo enabled auto-merge (squash) February 23, 2025 06:51
@ludoo ludoo merged commit 1dce672 into GoogleCloudPlatform:master Feb 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants