Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dns_keys output in dns module #2915

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix dns_keys output in dns module #2915

merged 2 commits into from
Feb 20, 2025

Conversation

nathou
Copy link
Contributor

@nathou nathou commented Feb 20, 2025

#1728 introduced a count for the google_dns_keys.dns_keys data source, but the corresponding output was not updated accordingly.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@nathou nathou marked this pull request as ready for review February 20, 2025 09:36
ludoo
ludoo approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR :)

@ludoo ludoo enabled auto-merge (squash) February 20, 2025 09:45
@ludoo ludoo merged commit a15d1a3 into GoogleCloudPlatform:master Feb 20, 2025
14 checks passed
@nathou nathou deleted the dns-keys-output branch February 20, 2025 09:58
nathou added a commit to Echo-analytics/cloud-foundation-fabric that referenced this pull request Feb 20, 2025
@nathou
output dns_keys instead of a list (GoogleCloudPlatform#2915)
b1c88e1 
* output dns_keys instead of a list

* access list items with square brackets according to linter
@ludoo ludoo changed the title output dns_keys instead of a list Fix dns_keys output in dns module Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathou @ludoo