Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for max workstations, refactor timeouts in workstation-cluster module #2911

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Feb 19, 2025

Breaking Changes

`modules/workstation-cluster`: changed the interface for configuration timeouts to object, timeouts are now specified as numbers.

@ludoo ludoo enabled auto-merge (squash) February 19, 2025 09:30
Copy link
Collaborator

@sruffilli sruffilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one qq: does this still need to use google-beta?

@ludoo ludoo added the breaks:modules Breaking changes in a module interface or resources. label Feb 19, 2025
@ludoo
Copy link
Collaborator Author

ludoo commented Feb 19, 2025

LGTM - one qq: does this still need to use google-beta?

yep, according to the resource docs it does; good call, let's remember to revisit periodically (actually, we should do it for all modules once in a while)

@ludoo ludoo merged commit 427763f into master Feb 19, 2025
18 checks passed
@ludoo ludoo deleted the ludo/workstation-module branch February 19, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks:modules Breaking changes in a module interface or resources. on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants