Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to VPC-SC directional policies #2909

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Feb 18, 2025


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Breaking changes

`modules/vpc-sc`: Referencing ingress/egress policies that are not defined results in an error (previously, undefined directional policies were silently ignored)

@juliocc juliocc force-pushed the jccb/vpc-sc-directional-policy-title branch from 26e1d6e to ee16097 Compare February 18, 2025 20:16
@github-actions github-actions bot added on:tools New or changed tool on:blueprints labels Feb 18, 2025
@juliocc juliocc force-pushed the jccb/vpc-sc-directional-policy-title branch from 1d9ab00 to af9be04 Compare February 18, 2025 20:39
@juliocc
Copy link
Collaborator Author

juliocc commented Feb 19, 2025

Waiting for hashicorp/terraform-provider-google#21493 to be fixed before merging.

@juliocc juliocc force-pushed the jccb/vpc-sc-directional-policy-title branch from c4061d8 to 10e608f Compare February 19, 2025 17:13
@juliocc juliocc enabled auto-merge (squash) February 19, 2025 17:20
@juliocc juliocc merged commit 21253a1 into fast-dev Feb 20, 2025
19 checks passed
@juliocc juliocc deleted the jccb/vpc-sc-directional-policy-title branch February 20, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants