Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DRS and essential contact domains to factory #2878

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Move DRS and essential contact domains to factory #2878

merged 2 commits into from
Feb 11, 2025

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Feb 11, 2025 •
edited
Loading

Upgrade note:

fast/stages/0-boostrap: if you use `var.org_policies_config.constraints.allowed_policy_member_domains` or `var.org_policies_config.constraints.allowed_policy_member_domains`, move their values to a YAML file under bootstrap's org policy factory.

ludoo
ludoo approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Do we need to also change something in the docs?

@juliocc
Copy link
Collaborator Author

juliocc commented Feb 11, 2025

This is awesome. Do we need to also change something in the docs?

Good point. Let take a look

@juliocc juliocc enabled auto-merge (squash) February 11, 2025 15:56
@juliocc juliocc merged commit 4dc61aa into fast-dev Feb 11, 2025
18 checks passed
@juliocc juliocc deleted the jccb/drs-factory branch February 11, 2025 16:36
@ludoo ludoo mentioned this pull request Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @ludoo