Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KMS E2E tests #2871

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Fix KMS E2E tests #2871

merged 2 commits into from
Feb 9, 2025

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 8, 2025

Add var.prefix to keyring names, as they are not removed on destroy. This allows retried E2E tests to complete.

Fix creation of E2E sandbox, so all necessary files are created and random var.prefix value is set.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@github-actions github-actions bot added on:tools New or changed tool on:modules labels Feb 8, 2025
@wiktorn
Copy link
Collaborator Author

wiktorn commented Feb 8, 2025

E2E test run

@wiktorn wiktorn enabled auto-merge (rebase) February 9, 2025 06:34
@wiktorn wiktorn merged commit 4e5c0ac into master Feb 9, 2025
18 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-compute-vm-schedule branch February 9, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @juliocc