-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cAdvisor Metrics to Autopilot/Standard GKE Cluster #2841
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @HeiglAnna, could you please take a look at the failing tests so we can merge this? Thanks! |
@juliocc I'm not quite sure on the linting errors in the documentation Checking locally, there are no errors in the lint.sh nor check_documentation |
I've sent you a PR with the fixes. Merge it to your branch and then everything should pass here. |
All good now. Thanks for your contribution @AnnaHeigl! |
…atform#2841) * Add cAdvisor Metrics to Autopilot/Standard GKE Cluster * Fix tests --------- Co-authored-by: AnnaHeigl <[email protected]> Co-authored-by: Julio Castillo <[email protected]>
Added cAdvisor to the Monitoring Block to be able to collect and view cAdvisor metrics in Cloud Monitoring.
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py