Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cAdvisor Metrics to Autopilot/Standard GKE Cluster #2841

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

HeiglAnna
Copy link
Contributor

Added cAdvisor to the Monitoring Block to be able to collect and view cAdvisor metrics in Cloud Monitoring.


Checklist

I applicable, I acknowledge that I have:

  • [x ] Read the contributing guide
  • [ x] Ran terraform fmt on all modified files
  • [ x] Regenerated the relevant README.md files using tools/tfdoc.py
  • [ x] Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Jan 28, 2025

Hi @HeiglAnna, could you please take a look at the failing tests so we can merge this?

Thanks!

@HeiglAnna
Copy link
Contributor Author

@juliocc I'm not quite sure on the linting errors in the documentation

Checking locally, there are no errors in the lint.sh nor check_documentation

@juliocc
Copy link
Collaborator

juliocc commented Jan 30, 2025

@juliocc I'm not quite sure on the linting errors in the documentation

Checking locally, there are no errors in the lint.sh nor check_documentation

I've sent you a PR with the fixes. Merge it to your branch and then everything should pass here.

@juliocc juliocc enabled auto-merge (squash) January 30, 2025 13:17
@juliocc juliocc merged commit efa1ef6 into GoogleCloudPlatform:master Jan 30, 2025
14 checks passed
@juliocc
Copy link
Collaborator

juliocc commented Jan 30, 2025

All good now. Thanks for your contribution @AnnaHeigl!

karpok78 pushed a commit to karpok78/cloud-foundation-fabric that referenced this pull request Feb 8, 2025
…atform#2841)

* Add cAdvisor Metrics to Autopilot/Standard GKE Cluster

* Fix tests

---------

Co-authored-by: AnnaHeigl <[email protected]>
Co-authored-by: Julio Castillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants