Allow multiple stage-2 project factories #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Jan 23, 2025
ludoo
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
I really like this. The only thing that bugs me is what we were discussing in chat: project-factory-pf.
Why don't we call our default project factory teams? So names would be
project-factory-teamsfor files-teams-0,teams-0retc for service accounts
PS - remember to also check the name patterns variable, we might need a new template string there for the project factories now.
juliocc
force-pushed
the
jccb/s2-multi-pf
branch
from
093d0e1 to
0ee7de5
Compare
juliocc
added
the
breaks:fast
ludoo
added a commit
that referenced
this pull request
Jan 26, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.