Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST SWP networking add-on, refactor CAS module interface #2821

Merged
merged 19 commits into from
Jan 18, 2025
Merged

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jan 17, 2025

No description provided.

@ludoo ludoo changed the title WIP - FAST SWP networking add-on FAST SWP networking add-on Jan 17, 2025
@ludoo ludoo marked this pull request as ready for review January 17, 2025 16:08
@ludoo ludoo enabled auto-merge (squash) January 17, 2025 16:13
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Left a few cosmetic comments below.

@ludoo ludoo merged commit f646e85 into fast-dev Jan 18, 2025
18 checks passed
@ludoo ludoo deleted the ludo/fast-swp branch January 18, 2025 07:12
@ludoo ludoo added the breaks:modules Breaking changes in a module interface or resources. label Jan 18, 2025
@ludoo ludoo changed the title FAST SWP networking add-on FAST SWP networking add-on, refactor CAS module interface Jan 18, 2025
karpok78 pushed a commit to karpok78/cloud-foundation-fabric that referenced this pull request Jan 19, 2025
* prototype implementation, untested

* halfway through refactor

* refactor cas module pool variable

* apply cas module refactor to ngfw fast addon

* untested

* test

* tflint

* tflint

* tfdoc

* fix brainfarts

* tfdoc

* update ca pool type in security stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks:modules Breaking changes in a module interface or resources. on:FAST on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants