Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restructure how var files are provided to workflow templates #2813

Conversation

Liam-Johnston
Copy link
Contributor


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Jan 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Jan 13, 2025

Can you please

  • explain the use-case and rationale of your change
  • target fast-dev as we do FAST development there

@Liam-Johnston Liam-Johnston changed the base branch from master to fast-dev January 13, 2025 22:22
@Liam-Johnston
Copy link
Contributor Author

Hey @ludoo,

The reason this is being implemented is because the stage 2-project-factory references variables from the stage 2-networking which currently don't get included in the github or gitlab workflow file that is generated by the 1-resource-management stage. see HERE

This change modifies the way the template file variables are populated in the 1-resource-management stage to follow a similar pattern to the way it works in the 0-bootstrap stage.

@Liam-Johnston Liam-Johnston force-pushed the feat/modify-resman-workflow-var-files branch from 9a178ed to a382246 Compare January 14, 2025 00:21
@Liam-Johnston Liam-Johnston force-pushed the feat/modify-resman-workflow-var-files branch from a382246 to 46cd583 Compare January 14, 2025 00:23
@ludoo ludoo merged commit ec59f70 into GoogleCloudPlatform:fast-dev Jan 14, 2025
14 checks passed
@Liam-Johnston Liam-Johnston deleted the feat/modify-resman-workflow-var-files branch January 14, 2025 22:25
karpok78 pushed a commit to karpok78/cloud-foundation-fabric that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants