Add optional support for fw policies via new vpc_configs variable, refactor factories variable in net stages #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
reviewed
Jan 8, 2025
…m/cloud-foundation-fabric into ludo/net-vpc-fw-order
ludoo
changed the title
ludoo
changed the title
juliocc
approved these changes
Jan 9, 2025
karpok78
pushed a commit
to karpok78/cloud-foundation-fabric
that referenced
this pull request
Jan 19, 2025
…factor factories variable in net stages (GoogleCloudPlatform#2801) * net a * extend change to other networking stages * refactor factories config variable in net a * net b and c * complete net b * fix errors, add mtu * fix * fix * fix errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for firewall policies to the
anetworking stage (the other stages will also be updated if the approach is agreed upon), via avpc_configsvariable.The variable is also used to concentrate some existing functionality which was previously scattered among other variables, and allow flipping cloudnat, DNS, and firewall bits for individual VPCs where the same configuration was previously applied to all VPC unconditionally.
From the point of view of resources this does not change anything, but it allows leveraging firewall policies especially in connection with NGFW, controlling the firewall precedence between classic and policies, and turning off classic firewalls entirely if needed. I actually need this for a project I'm working on, and I think it's high time we started supporting firewall policies.