Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cycle in the autopilot-cluster blueprint #2790

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 29, 2024

Without this change, terraform errors with:
│ Error: Cycle: module.project.google_storage_bucket_iam_member.gcs-sinks-binding, module.project.google_project_iam_member.project-sinks-binding, module.project.google_essential_contacts_contact.contact, module.project.google_bigquery_dataset_iam_member.bq-sinks-binding, module.project.google_project_iam_member.bucket-sinks-binding, module.project (close), module.project.output.sink_writer_identities (expand), local.cluster_sa (expand), module.project.var.iam_bindings_additive (expand), module.project.google_project_iam_member.bindings, module.project.google_logging_project_sink.sink, module.project.google_pubsub_topic_iam_member.pubsub-sinks-binding

The actual error is wrong variable reference. 🤷

Maybe we need add tests for those blueprints

Closes: #2789


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Closes: #2789


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Without this change, terraform errors with:
│ Error: Cycle: module.project.google_storage_bucket_iam_member.gcs-sinks-binding, module.project.google_project_iam_member.project-sinks-binding, module.project.google_essential_contacts_contact.contact, module.project.google_bigquery_dataset_iam_member.bq-sinks-binding, module.project.google_project_iam_member.bucket-sinks-binding, module.project (close), module.project.output.sink_writer_identities (expand), local.cluster_sa (expand), module.project.var.iam_bindings_additive (expand), module.project.google_project_iam_member.bindings, module.project.google_logging_project_sink.sink, module.project.google_pubsub_topic_iam_member.pubsub-sinks-binding

The actual error is wrong variable reference.

Closes: #2789
@wiktorn wiktorn enabled auto-merge (rebase) December 29, 2024 18:47
@wiktorn wiktorn merged commit 76b108d into master Dec 29, 2024
18 checks passed
@wiktorn wiktorn deleted the wiktorn-fix-gke-autopilot-bp branch December 29, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycle Error in terraform apply for autopilot-cluster
2 participants