Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confidential compute support to google_dataproc_cluster module, bump provider versions #2736

Conversation

steenblik
Copy link
Collaborator

@steenblik steenblik commented Nov 27, 2024

Add confidential compute support to dataproc module.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@steenblik
Copy link
Collaborator Author

Awaiting provider release. See: GoogleCloudPlatform/magic-modules#12397

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason!

@steenblik
Copy link
Collaborator Author

@ludoo - The updated 6.13.0 provider has finally been released. How should I proceed? I guess I should update the provider requirements across all modules but would like confirmation.

@ludoo
Copy link
Collaborator

ludoo commented Dec 10, 2024

@ludoo - The updated 6.13.0 provider has finally been released. How should I proceed? I guess I should update the provider requirements across all modules but would like confirmation.

find . -name versions.tf -exec cp default-versions.tf {} \; :)

After having updated default-versions.tf of course.

@steenblik
Copy link
Collaborator Author

find . -name versions.tf -exec cp default-versions.tf {} \; :)

Brilliant. Thanks!

ludoo and others added 15 commits December 10, 2024 13:47
…ogleCloudPlatform#2749)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.1 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.1...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rm#2748)

* Add ability to optionally generate MD5 secrets in VPN module

* Add ability to autogenerate MD5 keys in net-vpn-ha module

* restore missing output

* fix test counts

---------

Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.1 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.1...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oudPlatform#2755)

The Parent resource has a default to europe-west1 when it should be for the resource block from where the cloud run actually is.

Changed to use the var.region instead
…pp-ext (required for React apps for example).
…reign support (GoogleCloudPlatform#2750)

* add disk encyption key to the google_compute_instance_template

* add a condition to the kms_key_self_link

* use dynamic variable for disk_encryption_key

* remove the getpip from the repo

---------

Co-authored-by: Julio Castillo <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
…CloudPlatform#2740)

* add support for password validation policy to cloudsql module

* fix defaults
@steenblik steenblik force-pushed the feat/dataproc-confidential-compute branch from 9e97e14 to 0ff7fa8 Compare December 10, 2024 12:50
@github-actions github-actions bot removed the on:FAST label Dec 10, 2024
@steenblik steenblik marked this pull request as ready for review December 10, 2024 13:43
@steenblik
Copy link
Collaborator Author

@ludoo - I believe this one is ready. Do you want to have one more look?

@ludoo
Copy link
Collaborator

ludoo commented Dec 10, 2024

Go ahead and hit the green button :)

@steenblik steenblik merged commit 90360c5 into GoogleCloudPlatform:master Dec 10, 2024
14 checks passed
@ludoo ludoo changed the title Add confidential compute support to google_dataproc_cluster in the da… Add confidential compute support to google_dataproc_cluster module, bump provider versions Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants