Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path_template_match and path_template_rewrite support to net-lb-app-ext #2718

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

rosmo
Copy link
Collaborator

@rosmo rosmo commented Nov 19, 2024

Required for React apps for example: https://github.com/rosmo/react-app-cloud-function-gcs-bucket

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator

wiktorn commented Nov 19, 2024

Is this also supported for:

  • modules/net-lb-app-ext-regional
  • modules/net-lb-app-int-cross-region
  • modules/net-lb-app-int
    ?

Would be great to keep those in sync.

@rosmo
Copy link
Collaborator Author

rosmo commented Nov 19, 2024

Let me have a look, you might be right. It's an Envoy feature, so everything GFE3 based should be working...

@rosmo
Copy link
Collaborator Author

rosmo commented Nov 19, 2024

There, I added the rest of them.

@rosmo
Copy link
Collaborator Author

rosmo commented Nov 19, 2024

Ah, looks like google_compute_region_url_map hasn't been updated with these vars, will revert those.

@wiktorn
Copy link
Collaborator

wiktorn commented Nov 19, 2024

Ah, looks like google_compute_region_url_map hasn't been updated with these vars, will revert those.

I'm not sure I follow that. I see both path_template_match in path_template_rewrite in the resource.

@ludoo
Copy link
Collaborator

ludoo commented Dec 8, 2024

Ah, looks like google_compute_region_url_map hasn't been updated with these vars, will revert those.

I'm not sure I follow that. I see both path_template_match in path_template_rewrite in the resource.

What's missing to merge this?

@wiktorn
Copy link
Collaborator

wiktorn commented Dec 9, 2024

I just added support for ILBs

@wiktorn wiktorn merged commit 3f86056 into GoogleCloudPlatform:master Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants