New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modules/secret-manager): add support for version_destroy_ttl #2645

Merged

wiktorn merged 1 commit into GoogleCloudPlatform:master from frits-v:feat/secrets-destroy-ttl

Oct 30, 2024

Collaborator

frits-v commented Oct 29, 2024

Closes #2644

Checklist

I applicable, I acknowledge that I have:

Read the contributing guide
Ran terraform fmt on all modified files
Regenerated the relevant README.md files using tools/tfdoc.py
Made sure all relevant tests pass


          feat(modules/secret-manager): add support for version_destroy_ttl

4de208c

Closes GoogleCloudPlatform#2644

github-actions bot added the on:modules label

wiktorn approved these changes

View reviewed changes

wiktorn merged commit b9fbdbc into GoogleCloudPlatform:master

14 checks passed

Collaborator

wiktorn commented Oct 30, 2024

Thanks for clean PR @frits-v !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels