Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Project Factory Logging Data Option #2625

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Add Project Factory Logging Data Option #2625

merged 4 commits into from
Oct 17, 2024

Conversation

joshw123
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@joshw123 joshw123 changed the title Allow project factory logging data Add Project Factory Logging Data Option Oct 15, 2024
ludoo
ludoo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean, thanks for this.

@joshw123
Copy link
Contributor Author

Very nice and clean, thanks for this.

Thank You ❤️ Could you merge when you get a chance please? 😄

@juliocc juliocc enabled auto-merge (squash) October 17, 2024 10:42
@juliocc juliocc merged commit d4cff3e into GoogleCloudPlatform:master Oct 17, 2024
14 checks passed
@joshw123 joshw123 deleted the AllowProjectFactoryLoggingData branch October 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshw123 @ludoo @juliocc