-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the new iam interface in artifact-registry
#2606
feat: implement the new iam interface in artifact-registry
#2606
Conversation
2ad1258
to
3171c69
Compare
Thanks a lot for this. Can you also add relevant examples and inventories to the README? The contributing guide explains how those work, or ping here if you need a quick leg up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments:
- Move the IAM-related variables to variables-iam.tf
- Move the IAM-related resources to iam.tf
- Add the required dependencies to outputs
- Make sure to implement the full interface explained here
3171c69
to
87906a6
Compare
Working on the tests sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick response :)
Just one small detail with the moved block and we're good to go
19a8c19
to
7725959
Compare
Co-authored-by: Julio Castillo <[email protected]>
7725959
to
f631f37
Compare
This PR implements the new IAM interface in the
atifact-registry
module (#2605)In order to have a consistent interface across the different modules, this update will cause a delete/create of the existing permissions set in the
iam
variable:Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py