Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added biglake-catalog module #2572

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Added biglake-catalog module #2572

merged 1 commit into from
Sep 24, 2024

Conversation

apichick
Copy link
Collaborator

Added biglake-catalog module


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments. I think this is pretty niche resource, not sure whether this should go in, as the resource chain is pretty straightforward to build

@apichick apichick force-pushed the biglake branch 4 times, most recently from 9497adc to 4f7107f Compare September 19, 2024 10:57
@apichick
Copy link
Collaborator Author

changes done

@ludoo
Copy link
Collaborator

ludoo commented Sep 24, 2024

@apichick is this still planned for merge or should we close it?

@apichick apichick merged commit 3fad964 into master Sep 24, 2024
18 checks passed
@apichick apichick deleted the biglake branch September 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants