Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigquery dataset routines #2570

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Bigquery dataset routines #2570

merged 3 commits into from
Sep 19, 2024

Conversation

apichick
Copy link
Collaborator

Added routines to bigquery-dataset module


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick force-pushed the bigquery-dataset-routines branch from c8f02ed to 7a8c987 Compare September 14, 2024 20:44
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few nits here and there.

@apichick apichick force-pushed the bigquery-dataset-routines branch 2 times, most recently from a74454d to f8267fa Compare September 19, 2024 08:30
@apichick apichick force-pushed the bigquery-dataset-routines branch from f8267fa to 78adcd5 Compare September 19, 2024 08:32
@apichick apichick enabled auto-merge (squash) September 19, 2024 09:02
@apichick apichick merged commit 8e0dac8 into master Sep 19, 2024
18 checks passed
@apichick apichick deleted the bigquery-dataset-routines branch September 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants