New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update variables.tf #2558

Merged

eliamaldini merged 3 commits into master from em-nva-fix

Sep 16, 2024

Collaborator

eliamaldini commented Sep 5, 2024 •

edited

Loading

Hi Team,
the default ranges for the dmz are not valid ranges and they don't contain the default subnets of dmz factory.

Check this subnetting

Checklist

I applicable, I acknowledge that I have:

Read the contributing guide
Ran terraform fmt on all modified files
Regenerated the relevant README.md files using tools/tfdoc.py
Made sure all relevant tests pass


          Update variables.tf

8b20e46

Hi Team,
the default ranges for the dmz are not valid ranges that contain the default subnets.

This is the subnetting:
https://visualsubnetcalc.com/index.html?c=1N4IgbiBcIIwgNCAzlUMAMA6LOD0AOVWHbbXATiI1LwyIH0A7KEBEegYxZAF9FqAbABYauOpDRZhomHAnFM02gCYqUkbQDMaxRrIwhOpfoCsRvejEDzMgOwNm0AC4AnAK5InAUwAmAAgAHFwBLAFsAQxcATzZObj4FaRhlfH17eSYWH1CAL0CQiOjYrmheBMETGWt5CrsHbkQ40vKpSuTUyxh00EzSxpLWHiH+KQEZMwzHVn74lsUO-UMaqQXOicl5qvroHy8wfLDImJnmkcVyLcmG9gGys9sSNe3pm9m522UZbWXMD5kljZ-WjrBRA-TVHpTIIAe38QUORROg3umkukOuTUG7wsYhBvRemLuoLGtAB7CmxTeZ3wjzEqh+NK+OkZpOZtJgIOoLPBbLqV2c7k8vj8SC8HGhjB8R0ppwUjPaaWe2TyovFkulSKJXJgaLlOto3XJGNuc3wOoVnUN+JlWNNn2BzxtWqw+BxBmZbs5LrdEKNOz2IrFEqliNesq5lVovutmuGcpJpkdsbjXNWYm+G3wafdDOzXswWd1+Jh-lVwY1YeRcouUaTledmHI7LxFOTZ3I9sWdcJQxTWHICc6cnRfXrvbOFrIlH5BJNvaAA

github-actions bot added the on:FAST label

eliamaldini added 2 commits

September 16, 2024 10:12


          Merge branch 'master' into em-nva-fix

d558c93


          fixed readme file

1315bc9

sruffilli approved these changes

View reviewed changes

Collaborator Author

eliamaldini commented Sep 16, 2024

fixed default gcp_ranges

eliamaldini enabled auto-merge (squash)

September 16, 2024 08:21

eliamaldini merged commit 0e14cd5 into master

18 checks passed

eliamaldini deleted the em-nva-fix branch

September 16, 2024 08:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels