Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing aws_v4_authentication configuration in global external alb #2539

Merged
merged 18 commits into from
Aug 29, 2024

Conversation

okguru1
Copy link
Contributor

@okguru1 okguru1 commented Aug 29, 2024

Exposing aws_v4_authentication configuration in global external alb


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments below.

@okguru1
Copy link
Contributor Author

okguru1 commented Aug 29, 2024

Left a few comments below.

Fixed

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick changes.

This lgtm now!

@juliocc juliocc enabled auto-merge (squash) August 29, 2024 13:35
@juliocc juliocc merged commit dc0a27b into GoogleCloudPlatform:master Aug 29, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants