Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add security_policy to backend service configuration #2523

Merged
merged 2 commits into from
Aug 27, 2024
Merged

feat: Add security_policy to backend service configuration #2523

merged 2 commits into from
Aug 27, 2024

Conversation

EmileHofsink
Copy link
Contributor

The existing net-lb-app-int module doesn't support security_policy which is required to attach Cloud Armor Policies to backends.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@EmileHofsink EmileHofsink marked this pull request as ready for review August 27, 2024 11:19
@juliocc
Copy link
Collaborator

juliocc commented Aug 27, 2024

@ludoo lbs are your thing. Can you tal?

@juliocc juliocc requested a review from ludoo August 27, 2024 11:54
@ludoo ludoo merged commit 6cf0e57 into GoogleCloudPlatform:master Aug 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmileHofsink @juliocc @ludoo