Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e pubusb errors #2520

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add e2e pubusb errors #2520

merged 1 commit into from
Aug 26, 2024

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Aug 26, 2024

Adds pubsub to the list of jitsi service accounts for the default project.

I wonder how this was working in the past...

@juliocc juliocc requested a review from wiktorn August 26, 2024 11:33
@github-actions github-actions bot added the on:tools New or changed tool label Aug 26, 2024
@wiktorn
Copy link
Collaborator

wiktorn commented Aug 26, 2024

I was thinking about different approach for that - to create explicit depends_on for IAM grants, that are in fixtures for the tests that are failing. It looks like:

  • sometimes pubsub SA is missing permissions for GCS bucket
  • sometimes cloud function SA is missing permissions on pubsub

(at least based on last execution).

And this could explain, why it works sometimes.

@wiktorn
Copy link
Collaborator

wiktorn commented Aug 26, 2024

I mean, test case should depend on grants given in: fixtures/functions-default-sa-iam-grants.tf and fixtures/gcs.tf.

There might be other cases for that.

@juliocc
Copy link
Collaborator Author

juliocc commented Aug 26, 2024

It's not just the Ian binding, you also have to trigger the creation of the service agent

@juliocc juliocc merged commit 58bee2a into master Aug 26, 2024
18 checks passed
@juliocc juliocc deleted the jccb/fix-pubusb-e2e-service-agent branch August 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants